Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new architecture support #649

Merged
merged 15 commits into from
May 15, 2023
Merged

feat: new architecture support #649

merged 15 commits into from
May 15, 2023

Conversation

vonovak
Copy link
Collaborator

@vonovak vonovak commented May 15, 2023 •
edited
Loading

Summary

new arch requires RN 71

supersedes #631 #588

closes #631, closes #588

Test Plan

tested locally

Compatibility

OS Implemented
iOS ✅
Android ✅

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)

@vonovak vonovak marked this pull request as ready for review May 15, 2023 18:43
@vonovak vonovak changed the title Feat/new arch review feat: new architecture support May 15, 2023
@vonovak vonovak merged commit fc1c0f2 into master May 15, 2023
@vonovak vonovak deleted the feat/new-arch-review branch May 15, 2023 19:56
@RichardFevrier
Copy link
Collaborator

RichardFevrier commented Jul 10, 2023 •
edited
Loading

Thanks @vonovak and all the people involved in this work, you even used TurboReactPackage which is currently the best in class way to implement it.
Thanks again 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vonovak @RichardFevrier @WoLewicki